[ 
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291343#comment-16291343
 ] 

Mike Drob commented on HBASE-18838:
-----------------------------------

bq. Guessing hadoop got rid of htrace-core from their deps too and that testing 
against hadoop3 passes locally 
Nope. What's going on here is that maven exclusions in modules overwrite the 
exclusions in the parent, they are not additive. So by removing the htrace 
exclusion here, we get to use the full exclusion list from parent pom.

bq. patch is adding lines with 0 indent. 
will take a look and fix this.

bq. Since you introduced shaded.prefix
I was debating this, will go ahead and do it since you asked nicely.

bq. Add a separate exclusion, jic.
it doesn't show up in the maven dep tree, I think we're ok.

> shaded artifacts are incorrect when built against hadoop 3
> ----------------------------------------------------------
>
>                 Key: HBASE-18838
>                 URL: https://issues.apache.org/jira/browse/HBASE-18838
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: Sean Busbey
>            Assignee: Mike Drob
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, 
> HBASE-18838.v3.patch
>
>
> Building master/branch-2 against the hadoop-3 profile results in 
> check-invariants screaming about unrelocated dependencies. will list details 
> in comment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to