[ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197030#comment-13197030 ]
Phabricator commented on HBASE-5186: ------------------------------------ tedyu has commented on the revision "HBASE-5186 [jira] Add metrics to ThriftServer". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:126 We iterate underlyingQueue twice. Can we reduce to one iteration ? We can call underlyingQueue.clear() at the end. src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:125 Can we reuse the drainTo() at line 134 and specify Integer.MAX_VALUE here ? src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:141 Reduce to one iteration. src/main/java/org/apache/hadoop/hbase/thrift/HbaseHandlerMetricsProxy.java:34 Should read 'each call' REVISION DETAIL https://reviews.facebook.net/D1461 > Add metrics to ThriftServer > --------------------------- > > Key: HBASE-5186 > URL: https://issues.apache.org/jira/browse/HBASE-5186 > Project: HBase > Issue Type: Improvement > Reporter: Scott Chen > Assignee: Scott Chen > Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, > HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch, > HBASE-5186.D1461.6.patch, HBASE-5186.D1461.7.patch > > > It will be useful to have some metrics (queue length, waiting time, > processing time ...) similar to Hadoop RPC server. This allows us to monitor > system health also provide a tool to diagnose the problem where thrift calls > are slow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira