[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307282#comment-16307282 ]
BELUGA BEHR commented on HBASE-19678: ------------------------------------- [~tedyu] It wasn't. It was just moved up a few lines instead of being buried at the end of the method. Makes it more clear. I know I was surprised to find it down there all alone. > HBase Admin Security Capabilities Should Be Represented as a Set > ---------------------------------------------------------------- > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HBASE-19678.1.patch > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** > * Return the set of supported security capabilities. > * @throws IOException > * @throws UnsupportedOperationException > */ > List<SecurityCapability> getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)