[
https://issues.apache.org/jira/browse/HBASE-19703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311108#comment-16311108
]
Rajeshbabu Chintaguntla commented on HBASE-19703:
-------------------------------------------------
[~anoop.hbase]
bq.We can set Split policy at HTD level or using conf
'hbase.regionserver.region.split.policy'. At HM side also, when dealing with
split of a region, we can get this info right?
Right now are doing the same like setting the split policy to HTD so that it
will be initiated during region initialization.
bq. Ya u will have to create the instance newly. (In the old patch u were able
to directly get the split policy instance from HRegion)
Yes we need to create new split policy instance that requires HRegion but we
don't have that reference at master. With my old patch we are getting the
splitpolicy from HRegion
bq. Does this issue look like a regression? IMO old way of split policy usage
we should continue to have. Thanks for the finding.
Yes it's a regression and better to have old way of getting split policy but
seems like difficult without HRegion object present. So what I am thinking is
instead of using split policy we can make use column family attribute flag so
that based on flag we can take action whether to skip the check whether the
split key in the range of hfile boundaries or not.
> Functionality added as part of HBASE-12583 is not working after moving the
> split code to master
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-19703
> URL: https://issues.apache.org/jira/browse/HBASE-19703
> Project: HBase
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 2.0.0-beta-2
>
>
> As part of HBASE-12583 we are passing split policy to
> HRegionFileSystem#splitStoreFile so that we can allow to create reference
> files even the split key is out of HFile key range. This is needed for Local
> Indexing implementation in Phoenix. But now after moving the split code to
> master just passing null for split policy.
> {noformat}
> final String familyName = Bytes.toString(family);
> final Path path_first =
> regionFs.splitStoreFile(this.daughter_1_RI, familyName, sf, splitRow,
> false, null);
> final Path path_second =
> regionFs.splitStoreFile(this.daughter_2_RI, familyName, sf, splitRow,
> true, null);
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
