[ 
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329705#comment-16329705
 ] 

stack commented on HBASE-4224:
------------------------------

These should be our shaded, internal versions?

 
|import com.google.common.collect.Maps;|

 

Fix this ...  * @param name ame table or region to flush

Is the region name the full-on region name or just encoded name?

Should this be a method instead, an override of ServerName#valueOf?
|91|public ServerName(final byte[] serverName) {|
| | |92|this(Bytes.toString(serverName));|
| | |93|}|

 

Should ServerName be able to create invalid ServerNames? If not, then we'd not 
need isValid ?

 

Otherwise patch LGTM

> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
>                 Key: HBASE-4224
>                 URL: https://issues.apache.org/jira/browse/HBASE-4224
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: stack
>            Assignee: Chia-Ping Tsai
>            Priority: Major
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-4224.v0.patch, HBase-4224-v2.patch, 
> HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster.  logs are by 
> regionserver.  to let go of logs, we need to have all edits emptied from 
> memory.  only flush is by table or region.  We need to be able to flush the 
> regionserver.  Need to add this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to