[ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491239#comment-16491239 ]
Mike Drob commented on HBASE-20478: ----------------------------------- Been playing around with this locally, the problem according to checkstyle is that we're not consistent about wether we have blank lines between imports or not. That strikes me as overly pedantic, personally, but I can't find a way to turn off the checking entirely. It will either complain that we have too many extra lines, or not enough. May end up reaching out to checkstyle devs or hacking up a fork > move import checks from hbaseanti to checkstyle > ----------------------------------------------- > > Key: HBASE-20478 > URL: https://issues.apache.org/jira/browse/HBASE-20478 > Project: HBase > Issue Type: Improvement > Components: test > Reporter: Sean Busbey > Assignee: Mike Drob > Priority: Minor > Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, > HBASE-20478.2.patch, HBASE-20478.3.patch, HBASE-20478.4.patch, > HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch, > HBASE-anti-check.patch > > > came up in discussion on HBASE-20332. our check of "don't do this" things in > the codebase doesn't log the specifics of complaints anywhere, which forces > those who want to follow up to reverse engineer the check. -- This message was sent by Atlassian JIRA (v7.6.3#76005)