[
https://issues.apache.org/jira/browse/HBASE-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215127#comment-13215127
]
Hadoop QA commented on HBASE-5466:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515823/MetaScanner_HBASE_5466%282%29.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 152 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1030//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1030//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1030//console
This message is automatically generated.
> Opening a table also opens the metatable and never closes it.
> -------------------------------------------------------------
>
> Key: HBASE-5466
> URL: https://issues.apache.org/jira/browse/HBASE-5466
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.5, 0.92.0
> Reporter: Ashley Taylor
> Attachments: MetaScanner_HBASE_5466(2).patch,
> MetaScanner_HBASE_5466.patch
>
>
> Having upgraded to CDH3U3 version of hbase we found we had a zookeeper
> connection leak, tracking it down we found that closing the connection will
> only close the zookeeper connection if all calls to get the connection have
> been closed, there is incCount and decCount in the HConnection class,
> When a table is opened it makes a call to the metascanner class which opens a
> connection to the meta table, this table never gets closed.
> This caused the count in the HConnection class to never return to zero
> meaning that the zookeeper connection will not close when we close all the
> tables or calling
> HConnectionManager.deleteConnection(config, true);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
