[ 
https://issues.apache.org/jira/browse/HBASE-5466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215140#comment-13215140
 ] 

Zhihong Yu commented on HBASE-5466:
-----------------------------------

TestZooKeeper passed locally with patch v2.
{code}
+      }finally{
+        if(metaTable!=null){
{code}
There should be a space between } and finally, finally and {, if and (, ) and {

Overall, +1 on patch v2. Please fix formatting in v3.
                
> Opening a table also opens the metatable and never closes it.
> -------------------------------------------------------------
>
>                 Key: HBASE-5466
>                 URL: https://issues.apache.org/jira/browse/HBASE-5466
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.5, 0.92.0
>            Reporter: Ashley Taylor
>         Attachments: MetaScanner_HBASE_5466(2).patch, 
> MetaScanner_HBASE_5466.patch
>
>
> Having upgraded to CDH3U3 version of hbase we found we had a zookeeper 
> connection leak, tracking it down we found that closing the connection will 
> only close the zookeeper connection if all calls to get the connection have 
> been closed, there is incCount and decCount in the HConnection class,
> When a table is opened it makes a call to the metascanner class which opens a 
> connection to the meta table, this table never gets closed.
> This caused the count in the HConnection class to never return to zero 
> meaning that the zookeeper connection will not close when we close all the 
> tables or calling
> HConnectionManager.deleteConnection(config, true);    

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to