[ 
https://issues.apache.org/jira/browse/HBASE-20847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537861#comment-16537861
 ] 

Duo Zhang commented on HBASE-20847:
-----------------------------------

{quote}
Are we talking about the post-master crash scenario? Is the suggestion that 
sub-procedures just assume and put back in place the locks that were taken out 
by parent procedures when they run post-crash? And this will be ok as long as 
the parent waits on all sub-procedures to complete before it lets-go of shared 
or exclusive lock? (Which is how it currently works?).
{quote}

No, we will use HBASE-20846 to address the master restart problem. And here the 
problem is that, the parent procedure may not hold the shared/exclusive table 
lock in the normal cases, for example, SCP will not hold any table locks, but 
it will schedule AssignProcedures to make regions online. So we should change 
the implementation.

In HBASE-20846, the problem is that we need to restore the lock state before 
starting workers when master restarts.

> The parent procedure of RegionTransitionProcedure may not have the table lock
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20847
>                 URL: https://issues.apache.org/jira/browse/HBASE-20847
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2, Region Assignment
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-20847-v1.patch, HBASE-20847.patch
>
>
> For example, SCP can also schedule AssignProcedure and obviously it will not 
> hold the table lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to