[ 
https://issues.apache.org/jira/browse/HBASE-20847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539557#comment-16539557
 ] 

Allan Yang commented on HBASE-20847:
------------------------------------

{quote}
We need to release the exclusive lock if we are scheduling sub procedures. This 
is what we do for now.
{quote}
Are we doing this now? IIRC, we will hold the exclusive lock the whole life 
time even if we schedule sub procedures(if holdLock = true).

Just reviewed V3 patch, +1 on this patch, I think it totally resolves the 
problem of HBASE-20846. You can add the test case in HBASE-20846 to this patch, 
and resolve HBASE-20846 after this one.
For restoring locks after master restarts, I think we can open another issue to 
implement it, since it is a big change in AMv2.

> The parent procedure of RegionTransitionProcedure may not have the table lock
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20847
>                 URL: https://issues.apache.org/jira/browse/HBASE-20847
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2, Region Assignment
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-20847-v1.patch, HBASE-20847-v2.patch, 
> HBASE-20847-v3.patch, HBASE-20847.patch
>
>
> For example, SCP can also schedule AssignProcedure and obviously it will not 
> hold the table lock.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to