[
https://issues.apache.org/jira/browse/HBASE-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215840#comment-13215840
]
Hadoop QA commented on HBASE-5455:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515922/HBASE-5455.diff
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -133 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1043//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1043//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1043//console
This message is automatically generated.
> Add test to avoid unintentional reordering of items in HbaseObjectWritable
> --------------------------------------------------------------------------
>
> Key: HBASE-5455
> URL: https://issues.apache.org/jira/browse/HBASE-5455
> Project: HBase
> Issue Type: Test
> Reporter: Michael Drzal
> Assignee: Michael Drzal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-5455.diff
>
>
> HbaseObjectWritable has a static initialization block that assigns ints to
> various classes. The int is assigned by using a local variable that is
> incremented after each use. If someone adds a line in the middle of the
> block, this throws off everything after the change, and can break client
> compatibility. There is already a comment to not add/remove lines at the
> beginning of this block. It might make sense to have a test against a static
> set of ids. If something gets changed unintentionally, it would at least
> fail the tests. If the change was intentional, at the very least the test
> would need to get updated, and it would be a conscious decision.
> https://issues.apache.org/jira/browse/HBASE-5204 contains the the fix for one
> issue of this type.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
