[ https://issues.apache.org/jira/browse/HBASE-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216335#comment-13216335 ]
Hudson commented on HBASE-5455: ------------------------------- Integrated in HBase-TRUNK #2669 (See [https://builds.apache.org/job/HBase-TRUNK/2669/]) HBASE-5455 Add test to avoid unintentional reordering of items in HbaseObjectWritable (Michael Drzal) (Revision 1293455) Result = SUCCESS larsh : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java > Add test to avoid unintentional reordering of items in HbaseObjectWritable > -------------------------------------------------------------------------- > > Key: HBASE-5455 > URL: https://issues.apache.org/jira/browse/HBASE-5455 > Project: HBase > Issue Type: Test > Reporter: Michael Drzal > Assignee: Michael Drzal > Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5455.diff > > > HbaseObjectWritable has a static initialization block that assigns ints to > various classes. The int is assigned by using a local variable that is > incremented after each use. If someone adds a line in the middle of the > block, this throws off everything after the change, and can break client > compatibility. There is already a comment to not add/remove lines at the > beginning of this block. It might make sense to have a test against a static > set of ids. If something gets changed unintentionally, it would at least > fail the tests. If the change was intentional, at the very least the test > would need to get updated, and it would be a conscious decision. > https://issues.apache.org/jira/browse/HBASE-5204 contains the the fix for one > issue of this type. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira