[ 
https://issues.apache.org/jira/browse/HBASE-20853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540222#comment-16540222
 ] 

Chia-Ping Tsai commented on HBASE-20853:
----------------------------------------

{quote}but why does your code increment the value of a cell? It seems to be a 
checkAndDelete.
{quote}
Pardon me. I can't recall the comment because of bad memory. :(

What I want to to for Table#incrementColumnValue is shown below.
{code:java}
- default long incrementColumnValue(byte[] row, byte[] family, byte[] 
qualifier, long amount)
- throws IOException {
- throw new NotImplementedException("Add an implementation!");
+ default long incrementColumnValue(byte[] row, byte[] family, byte[] 
qualifier, long amount) throws IOException {
+ Cell cell = increment(new Increment(row).addColumn(family, qualifier, 
amount)).getColumnLatestCell(family, qualifier);
+ return Bytes.toLong(cell.getValueArray(), cell.getValueOffset(), 
cell.getValueLength());
{code}

> Polish "Add defaults to Table Interface so Implementors don't have to"
> ----------------------------------------------------------------------
>
>                 Key: HBASE-20853
>                 URL: https://issues.apache.org/jira/browse/HBASE-20853
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>            Assignee: Balazs Meszaros
>            Priority: Major
>              Labels: beginner, beginners
>             Fix For: 3.0.0, 2.0.2, 2.1.1
>
>         Attachments: HBASE-20853.master.001.patch
>
>
> This issue is to address feedback that came in after commit on the parent 
> (FYI [~chia7712]). See tail of parent issue and amendment attached to parent 
> adding better defaults to the Table Interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to