[ https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553234#comment-16553234 ]
Ted Yu commented on HBASE-20744: -------------------------------- [~huaxiang]: Can you take a look at the change to RegionServerQuotaManager ? Thanks > Address FindBugs warnings in branch-1 > ------------------------------------- > > Key: HBASE-20744 > URL: https://issues.apache.org/jira/browse/HBASE-20744 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Xu Cang > Priority: Major > Attachments: HBASE-20744.branch-1.001.patch > > > From > https://builds.apache.org/job/HBase%20Nightly/job/branch-1/350//JDK8_Nightly_Build_Report_(Hadoop2)/ > : > {code} > FindBugs module:hbase-common > Inconsistent synchronization of > org.apache.hadoop.hbase.io.encoding.EncodedDataBlock$BufferGrabbingByteArrayOutputStream.ourBytes; > locked 50% of time Unsynchronized access at EncodedDataBlock.java:50% of > time Unsynchronized access at EncodedDataBlock.java:[line 258] > {code} > {code} > FindBugs module:hbase-hadoop2-compat > java.util.concurrent.ScheduledThreadPoolExecutor stored into non-transient > field MetricsExecutorImpl$ExecutorSingleton.scheduler At > MetricsExecutorImpl.java:MetricsExecutorImpl$ExecutorSingleton.scheduler At > MetricsExecutorImpl.java:[line 51] > {code} > {code} > FindBugs module:hbase-server > instanceof will always return false in > org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region, > int, int, int), since a org.apache.hadoop.hbase.quotas.RpcThrottlingException > can't be a org.apache.hadoop.hbase.quotas.ThrottlingException At > RegionServerQuotaManager.java:in > org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region, > int, int, int), since a org.apache.hadoop.hbase.quotas.RpcThrottlingException > can't be a org.apache.hadoop.hbase.quotas.ThrottlingException At > RegionServerQuotaManager.java:[line 193] > instanceof will always return true for all non-null values in > org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region, > int, int, int), since all > org.apache.hadoop.hbase.quotas.RpcThrottlingException are instances of > org.apache.hadoop.hbase.quotas.RpcThrottlingException At > RegionServerQuotaManager.java:for all non-null values in > org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region, > int, int, int), since all > org.apache.hadoop.hbase.quotas.RpcThrottlingException are instances of > org.apache.hadoop.hbase.quotas.RpcThrottlingException At > RegionServerQuotaManager.java:[line 199] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)