[
https://issues.apache.org/jira/browse/HBASE-20744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553537#comment-16553537
]
Hadoop QA commented on HBASE-20744:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
48s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
35s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
12s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
48s{color} | {color:blue} hbase-common in branch-1 has 1 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} hbase-hadoop2-compat in branch-1 has 1 extant
Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
9s{color} | {color:blue} hbase-server in branch-1 has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color}
| {color:red} hbase-common generated 1 new + 41 unchanged - 1 fixed = 42 total
(was 42) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 15s{color}
| {color:red} hbase-hadoop2-compat generated 1 new + 38 unchanged - 1 fixed =
39 total (was 39) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
10s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
1m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} hbase-common generated 0 new + 0 unchanged - 1 fixed
= 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat generated 0 new + 0 unchanged -
1 fixed = 0 total (was 1) {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
55s{color} | {color:green} hbase-server generated 0 new + 0 unchanged - 2 fixed
= 0 total (was 2) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
2s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
23s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}112m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
48s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20744 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12932755/HBASE-20744.branch-1.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-143-generic #192-Ubuntu SMP Tue
Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | branch-1 / 2eaa24a |
| maven | version: Apache Maven 3.0.5
(r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 13:51:28+0000) |
| Default Java | 1.8.0_172 |
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/artifact/patchprocess/branch-shadedjars.txt
|
| findbugs | v3.1.0-RC1 |
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/artifact/patchprocess/diff-compile-javac-hbase-common.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/artifact/patchprocess/diff-compile-javac-hbase-hadoop2-compat.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/artifact/patchprocess/patch-shadedjars.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/testReport/ |
| modules | C: hbase-common hbase-hadoop2-compat hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13748/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Address FindBugs warnings in branch-1
> -------------------------------------
>
> Key: HBASE-20744
> URL: https://issues.apache.org/jira/browse/HBASE-20744
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Xu Cang
> Priority: Major
> Attachments: HBASE-20744.branch-1.001.patch,
> HBASE-20744.branch-1.002.patch
>
>
> From
> https://builds.apache.org/job/HBase%20Nightly/job/branch-1/350//JDK8_Nightly_Build_Report_(Hadoop2)/
> :
> {code}
> FindBugs module:hbase-common
> Inconsistent synchronization of
> org.apache.hadoop.hbase.io.encoding.EncodedDataBlock$BufferGrabbingByteArrayOutputStream.ourBytes;
> locked 50% of time Unsynchronized access at EncodedDataBlock.java:50% of
> time Unsynchronized access at EncodedDataBlock.java:[line 258]
> {code}
> {code}
> FindBugs module:hbase-hadoop2-compat
> java.util.concurrent.ScheduledThreadPoolExecutor stored into non-transient
> field MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:[line 51]
> {code}
> {code}
> FindBugs module:hbase-server
> instanceof will always return false in
> org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region,
> int, int, int), since a org.apache.hadoop.hbase.quotas.RpcThrottlingException
> can't be a org.apache.hadoop.hbase.quotas.ThrottlingException At
> RegionServerQuotaManager.java:in
> org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region,
> int, int, int), since a org.apache.hadoop.hbase.quotas.RpcThrottlingException
> can't be a org.apache.hadoop.hbase.quotas.ThrottlingException At
> RegionServerQuotaManager.java:[line 193]
> instanceof will always return true for all non-null values in
> org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region,
> int, int, int), since all
> org.apache.hadoop.hbase.quotas.RpcThrottlingException are instances of
> org.apache.hadoop.hbase.quotas.RpcThrottlingException At
> RegionServerQuotaManager.java:for all non-null values in
> org.apache.hadoop.hbase.quotas.RegionServerQuotaManager.checkQuota(Region,
> int, int, int), since all
> org.apache.hadoop.hbase.quotas.RpcThrottlingException are instances of
> org.apache.hadoop.hbase.quotas.RpcThrottlingException At
> RegionServerQuotaManager.java:[line 199]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
