[
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581523#comment-16581523
]
Sean Busbey commented on HBASE-21061:
-------------------------------------
precommit on HBASE-20895 didn't run findbugs:
{code}
00:00:30.499 Step 20/46 : RUN mkdir -p /opt/findbugs && curl -L -s -S
https://sourceforge.net/projects/findbugs/files/findbugs/3.0.1/findbugs-noUpdateChecks-3.0.1.tar.gz/download
-o /opt/findbugs.tar.gz && tar xzf /opt/findbugs.tar.gz
--strip-components 1 -C /opt/findbugs
00:00:30.500 ---> Using cache
00:00:30.500 ---> 9fd52b187bc9
00:00:30.500 Step 21/46 : ENV FINDBUGS_HOME /opt/findbugs
00:00:30.500 ---> Using cache
00:00:30.500 ---> 302e9c623019
{code}
{code}
00:00:43.956 executable '/usr/bin/findbugs' for 'findbugs' does not exist.
00:00:43.956 executable '/usr/bin/computeBugHistory' for 'computeBugHistory'
does not exist.
00:00:43.957 executable '/usr/bin/convertXmlToText' for 'convertXmlToText' does
not exist.
00:00:43.958 executable '/usr/bin/filterBugs' for 'filterBugs' does not exist.
00:00:43.959 executable '/usr/bin/setBugDatabaseInfo' for 'setBugDatabaseInfo'
does not exist.
{code}
{code}
0 findbugs 0m 0s Findbugs executables are not available.
{code}
the nightly build on branch-1 that posted back included a findbugs failure that
called the inconsistent use out ([results for build #395 if still up on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/395/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/].
compared to no findbugs failure on [results for build #394 if still up on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/394/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]).
But literally every sub-check on every branch that went up was red, as were
all of the top-level build histories for branches-1, so I'd guess it was just
noise.
Here's the first complaint on branch-1 in build #395
{code}
FindBugs module:hbase-server
Inconsistent synchronization of
org.apache.hadoop.hbase.ipc.RpcServer$Connection.connectionHeader; locked 81%
of time Unsynchronized access at RpcServer.java:81% of time Unsynchronized
access at RpcServer.java:[line 1371]
Inconsistent synchronization of
org.apache.hadoop.hbase.ipc.RpcServer$Connection.service; locked 57% of time
Unsynchronized access at RpcServer.java:57% of time Unsynchronized access at
RpcServer.java:[line 422]
Inconsistent synchronization of
org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time
Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at
RpcServer.java:[line 477]
{code}
> fix synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
> Key: HBASE-21061
> URL: https://issues.apache.org/jira/browse/HBASE-21061
> Project: HBase
> Issue Type: Sub-task
> Components: rpc
> Affects Versions: 1.5.0, 1.2.7, 1.3.3, 1.4.7
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at
> RpcServer.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
