[
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594235#comment-16594235
]
Mike Drob commented on HBASE-21061:
-----------------------------------
Soem thoughts:
{noformat}
public VersionInfo getVersionInfo() {
if (connectionHeader.hasVersionInfo()) {
return connectionHeader.getVersionInfo();
}
return null;
}
{noformat}
Shouldn't this just be {{return connectionHeader.getVersionInfo();}} since if
it doesn't have the version info we're going to be returning null anyway?
Looking at the other usages and unsynchronized instances... I don't think we
care? I think they happen to be synchronized some of the time because they're
in a big block, but otherwise they don't really matter.
> fix synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
> Key: HBASE-21061
> URL: https://issues.apache.org/jira/browse/HBASE-21061
> Project: HBase
> Issue Type: Sub-task
> Components: rpc
> Affects Versions: 1.5.0, 1.3.3, 1.2.7, 1.4.7
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at
> RpcServer.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
