[ 
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603506#comment-16603506
 ] 

Sean Busbey commented on HBASE-21061:
-------------------------------------

bq. I'd like to see the ternary operator replaced with a simple boolean 
conditional, but not enough to argue about it.

got it. I'm fixing this on commit unless something else requires an iteration 
on the patch.

bq. Can you file a follow on JIRA to figure out why findbugs isn't running in 
precommit?

Sure. probably the download of findbugs tools just failed.

> fix synchronization of 
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-21061
>                 URL: https://issues.apache.org/jira/browse/HBASE-21061
>             Project: HBase
>          Issue Type: Sub-task
>          Components: rpc
>    Affects Versions: 1.5.0, 1.3.3, 1.2.7, 1.4.7
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>         Attachments: HBASE-21061-branch-1.v0.patch
>
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of 
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time 
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at 
> RpcServer.java
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to