[
https://issues.apache.org/jira/browse/HBASE-21061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599027#comment-16599027
]
Sean Busbey commented on HBASE-21061:
-------------------------------------
{quote}
Failed junit tests hadoop.hbase.master.balancer.TestRegionLocationFinder
hadoop.hbase.client.TestRollbackFromClient
{quote}
Same unit test failures as my dedicated QA bot. Let me dig on that to make sure.
{quote}
{code}
final boolean canUseRequestTooBig = headerAndPreambleRead ?
VersionInfoUtil.hasMinimumVersion(connectionHeader.getVersionInfo(),
RequestTooBigException.MAJOR_VERSION,
RequestTooBigException.MINOR_VERSION)
: false;
{code}
Isn't this the same as
{code}
headerAndPreambleRead &&
VersionInfoUtil.hasMinimumVersion(connectionHeader.getVersionInfo(),
RequestTooBigException.MAJOR_VERSION,
RequestTooBigException.MINOR_VERSION);
{code}
I'm assuming we have to include the check for headerAndPreambleRead because
otherwise we get some exception or bad value on
connectionHeader.getVersionInfo? Otherwise it's part of the check later...
{quote}
Yeah I believe that's logically equivalent. Also clearer. It shouldn't change
the unit test so I'll try to check on that before updating.
I'm presuming the same thing on {{headerAndPreambleRead}}. I didn't dig in to
see if the existing check was needed for a specific reason.
> fix synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap
> -------------------------------------------------------------------------------
>
> Key: HBASE-21061
> URL: https://issues.apache.org/jira/browse/HBASE-21061
> Project: HBase
> Issue Type: Sub-task
> Components: rpc
> Affects Versions: 1.5.0, 1.3.3, 1.2.7, 1.4.7
> Reporter: Sean Busbey
> Assignee: Monani Mihir
> Priority: Critical
> Attachments: HBASE-21061-branch-1.v0.patch
>
>
> fix findbugs highlighted issue
> {code}
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer$Connection.useWrap; locked 75% of time
> Unsynchronized access at RpcServer.java:75% of time Unsynchronized access at
> RpcServer.java
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
