[
https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226893#comment-13226893
]
Phabricator commented on HBASE-5335:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5335] Dynamic Schema Config".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:41
HColumnDescriptor is used by client package.
Would this introduce extra dependency ?
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:106 wrap long
line, please.
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:531 Can this
method be unified with HColumnDescriptor.getKVs() ?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:452
regionInfo.getTableDesc() is an expensive method, in 0.92 and above.
Is there a way to avoid calling it ?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:445 This ctor
seems to be in 0.89-fb only.
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:1 Add
license, please.
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:39 Add
javadoc for the methods.
e.g. for getRaw():
* Get the value of the <code>key</code> property, without doing
* variable expansion.
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:81 This
can be removed, right ?
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:57
Minor:
If a return is added after this line, there is no need to introduce else
statement, saving some indentation.
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:160
What if a higher-priority ImmutableConfigMap in this.configs returns null but a
lower-priority ImmutableConfigMap returns non-null value ?
src/main/java/org/apache/hadoop/hbase/util/CompoundConfiguration.java:203 You
mean bug in Configuration.java :-)
REVISION DETAIL
https://reviews.facebook.net/D2247
> Dynamic Schema Configurations
> -----------------------------
>
> Key: HBASE-5335
> URL: https://issues.apache.org/jira/browse/HBASE-5335
> Project: HBase
> Issue Type: New Feature
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Labels: configuration, schema
> Attachments: D2247.1.patch
>
>
> Currently, the ability for a core developer to add per-table & per-CF
> configuration settings is very heavyweight. You need to add a reserved
> keyword all the way up the stack & you have to support this variable
> long-term if you're going to expose it explicitly to the user. This has
> ended up with using Configuration.get() a lot because it is lightweight and
> you can tweak settings while you're trying to understand system behavior
> [since there are many config params that may never need to be tuned]. We
> need to add the ability to put & read arbitrary KV settings in the HBase
> schema. Combined with online schema change, this will allow us to safely
> iterate on configuration settings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
