[
https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228732#comment-13228732
]
Phabricator commented on HBASE-5335:
------------------------------------
nspiegelberg has commented on the revision "[jira] [HBASE-5335] Dynamic Schema
Config".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java:736 okay. maybe
"getValues" since that's the variable name?
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java:571 yeah, I
think that HTD & HCD needs a lot of unification work beyond this.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:938 I'll
write more comments, there's a nasty issue here:
when you split, you take the 'conf' from the parent region and pass it into
the daughter region's constructor. If you passed in the CompoundConfiguration,
you would end up with using the HTD of the parent region and the new HTD of the
daughter region. You really need to pass the base Configuration object used by
HRegionServer to the daughter regions to avoid a tricky dedupe problem.
REVISION DETAIL
https://reviews.facebook.net/D2247
> Dynamic Schema Configurations
> -----------------------------
>
> Key: HBASE-5335
> URL: https://issues.apache.org/jira/browse/HBASE-5335
> Project: HBase
> Issue Type: New Feature
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Labels: configuration, schema
> Attachments: D2247.1.patch
>
>
> Currently, the ability for a core developer to add per-table & per-CF
> configuration settings is very heavyweight. You need to add a reserved
> keyword all the way up the stack & you have to support this variable
> long-term if you're going to expose it explicitly to the user. This has
> ended up with using Configuration.get() a lot because it is lightweight and
> you can tweak settings while you're trying to understand system behavior
> [since there are many config params that may never need to be tuned]. We
> need to add the ability to put & read arbitrary KV settings in the HBase
> schema. Combined with online schema change, this will allow us to safely
> iterate on configuration settings.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
