[ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-5542: -------------------------- Comment: was deleted (was: -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517843/HBASE-5542.D2217.6.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -120 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1156//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1156//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1156//console This message is automatically generated.) > Unify HRegion.mutateRowsWithLocks() and HRegion.processRow() > ------------------------------------------------------------ > > Key: HBASE-5542 > URL: https://issues.apache.org/jira/browse/HBASE-5542 > Project: HBase > Issue Type: Improvement > Reporter: Scott Chen > Assignee: Scott Chen > Fix For: 0.96.0 > > Attachments: HBASE-5542.D2217.1.patch, HBASE-5542.D2217.2.patch, > HBASE-5542.D2217.3.patch, HBASE-5542.D2217.4.patch, HBASE-5542.D2217.5.patch, > HBASE-5542.D2217.6.patch, HBASE-5542.D2217.7.patch > > > mutateRowsWithLocks() does atomic mutations on multiple rows. > processRow() does atomic read-modify-writes on a single row. > It will be useful to generalize both and have a > processRowsWithLocks() that does atomic read-modify-writes on multiple rows. > This also helps reduce some redundancy in the codes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira