[ 
https://issues.apache.org/jira/browse/HBASE-21890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767320#comment-16767320
 ] 

stack commented on HBASE-21890:
-------------------------------

Patch is good. I did not know that submit bypassed the inserted handler. Good 
find. Aborting the Master is too aggressive I think though it might be good to 
have it in Master for a while at least. We'll start to see exceptions that used 
to be suppressed after this change.

> Use execute instead of submit to submit a task in RemoteProcedureDispatcher
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-21890
>                 URL: https://issues.apache.org/jira/browse/HBASE-21890
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4
>
>         Attachments: HBASE-21890.patch
>
>
> Found this when implementing HBASE-21875, the UncaughtExceptionHandler will 
> not be invoked if you use submit to submit the task, as by design, you should 
> use the returned Future object to get the result(exception).
> As we do not care the return value here, let's change to use execute method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to