[
https://issues.apache.org/jira/browse/HBASE-21890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767541#comment-16767541
]
Xu Cang commented on HBASE-21890:
---------------------------------
Providing my 2 cents here. I have some concerns about "master.abort()" call
too. Skimming current code on master, we only do this kind of operation in 3
places. One is in RegionStateStore when region location cannot be updated.
Other two are in ActiveMasterManager when master node change cannot be handled
or master state transition has issue. Those cases are legit to abort master
because there are issues with master itself.
But in this case here, it's more about remote region server cannot handle
procedures for an unknown reason. It's not optimal, but I don't see it's
critical enough to abort master.
> Use execute instead of submit to submit a task in RemoteProcedureDispatcher
> ---------------------------------------------------------------------------
>
> Key: HBASE-21890
> URL: https://issues.apache.org/jira/browse/HBASE-21890
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Critical
> Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4
>
> Attachments: HBASE-21890.patch
>
>
> Found this when implementing HBASE-21875, the UncaughtExceptionHandler will
> not be invoked if you use submit to submit the task, as by design, you should
> use the returned Future object to get the result(exception).
> As we do not care the return value here, let's change to use execute method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
