[ https://issues.apache.org/jira/browse/HBASE-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232990#comment-13232990 ]
Phabricator commented on HBASE-5335: ------------------------------------ mbautin has commented on the revision "[jira] [HBASE-5335] Dynamic Schema Config". A couple more responses inline. INLINE COMMENTS src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:4246 This would be the right place for a new test like this if it were not as huge as it is now. Would it be difficult to add new unit tests into separate test classes? I have tried to do so when creating new tests and have not had much difficulties. src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java:4292 It would be great to add this explanation to the comment and/or make this delay a meaningfully-named constant and reuse it in both places. REVISION DETAIL https://reviews.facebook.net/D2247 > Dynamic Schema Configurations > ----------------------------- > > Key: HBASE-5335 > URL: https://issues.apache.org/jira/browse/HBASE-5335 > Project: HBase > Issue Type: New Feature > Reporter: Nicolas Spiegelberg > Assignee: Nicolas Spiegelberg > Labels: configuration, schema > Attachments: D2247.1.patch, D2247.2.patch, D2247.3.patch, > D2247.4.patch > > > Currently, the ability for a core developer to add per-table & per-CF > configuration settings is very heavyweight. You need to add a reserved > keyword all the way up the stack & you have to support this variable > long-term if you're going to expose it explicitly to the user. This has > ended up with using Configuration.get() a lot because it is lightweight and > you can tweak settings while you're trying to understand system behavior > [since there are many config params that may never need to be tuned]. We > need to add the ability to put & read arbitrary KV settings in the HBase > schema. Combined with online schema change, this will allow us to safely > iterate on configuration settings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira