[ 
https://issues.apache.org/jira/browse/HBASE-22250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821685#comment-16821685
 ] 

lixiaobao commented on HBASE-22250:
-----------------------------------

I find the
{code:java}
//代码占位符
hbase.master.kerberos.principal
hbase.master.keytab.file
hbase.regionserver.kerberos.principal
hbase.regionserver.keytab.file
{code}
used in hbase-client model and hbase-server model ,so I add a  class named 
org.apache.hadoop.hbase.security.SecurityConstants marked IA.Private to 
hbase-common model to gathering the constants.

 

> The same constants used in many places should be placed in constant classes
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-22250
>                 URL: https://issues.apache.org/jira/browse/HBASE-22250
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, conf, regionserver
>    Affects Versions: 1.2.0, 2.0.0, 2.1.1, 2.1.4
>            Reporter: lixiaobao
>            Assignee: lixiaobao
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-22250.patch, HBASE-22250_2.patch
>
>
> I think we should put these configurations in the HConstants class to avoid 
> the trouble of modifying a lot of places when we modify them later.
> {code:java}
> public static final String MASTER_KRB_PRINCIPAL = 
> "hbase.master.kerberos.principal";
> public static final String MASTER_KRB_KEYTAB_FILE = 
> "hbase.master.keytab.file";
> public static final String REGIONSERVER_KRB_PRINCIPAL = 
> "hbase.regionserver.kerberos.principal";
> public static final String REGIONSERVER_KRB_KEYTAB_FILE = 
> "hbase.regionserver.keytab.file";{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to