Apache9 commented on a change in pull request #168: HBASE-22271 Implement
grant/revoke/delete table acls/delete namespace acls in Procedure
URL: https://github.com/apache/hbase/pull/168#discussion_r283610557
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -836,18 +795,23 @@ public void
preDeleteTable(ObserverContext<MasterCoprocessorEnvironment> c, Tabl
@Override
public void postDeleteTable(ObserverContext<MasterCoprocessorEnvironment> c,
final TableName tableName) throws IOException {
- final Configuration conf = c.getEnvironment().getConfiguration();
- User.runAsLoginUser(new PrivilegedExceptionAction<Void>() {
- @Override
- public Void run() throws Exception {
- try (Table table =
-
c.getEnvironment().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME)) {
- PermissionStorage.removeTablePermissions(conf, tableName, table);
+ if (c.getEnvironment() instanceof HasMasterServices) {
+ User.runAsLoginUser(new PrivilegedExceptionAction<Void>() {
+ @Override
+ public Void run() throws Exception {
+ ProcedureExecutor<MasterProcedureEnv> masterProcedureExecutor =
+ ((HasMasterServices) c.getEnvironment()).getMasterServices()
+ .getMasterProcedureExecutor();
+ ProcedurePrepareLatch latch =
ProcedurePrepareLatch.createBlockingLatch();
Review comment:
Do we really need to wait here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
