Apache9 commented on a change in pull request #168: HBASE-22271 Implement
grant/revoke/delete table acls/delete namespace acls in Procedure
URL: https://github.com/apache/hbase/pull/168#discussion_r283610615
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -1146,19 +1110,23 @@ public void
preDeleteNamespace(ObserverContext<MasterCoprocessorEnvironment> ctx
@Override
public void
postDeleteNamespace(ObserverContext<MasterCoprocessorEnvironment> ctx,
final String namespace) throws IOException {
- final Configuration conf = ctx.getEnvironment().getConfiguration();
- User.runAsLoginUser(new PrivilegedExceptionAction<Void>() {
- @Override
- public Void run() throws Exception {
- try (Table table =
-
ctx.getEnvironment().getConnection().getTable(PermissionStorage.ACL_TABLE_NAME))
{
- PermissionStorage.removeNamespacePermissions(conf, namespace, table);
+ if (ctx.getEnvironment() instanceof HasMasterServices) {
+ User.runAsLoginUser(new PrivilegedExceptionAction<Void>() {
+ @Override
+ public Void run() throws Exception {
+ ProcedureExecutor<MasterProcedureEnv> masterProcedureExecutor =
+ ((HasMasterServices) ctx.getEnvironment()).getMasterServices()
+ .getMasterProcedureExecutor();
+ ProcedurePrepareLatch latch =
ProcedurePrepareLatch.createBlockingLatch();
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
