Apache9 commented on a change in pull request #343: HBASE-22634 : Improve
performance of BufferedMutator
URL: https://github.com/apache/hbase/pull/343#discussion_r297925473
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
##########
@@ -491,13 +482,13 @@ public void close() {
connToClose = connections.values();
connections.clear();
}
- cleanupIdleConnectionTask.cancel(true);
for (T conn : connToClose) {
- conn.shutdown();
+ // conn may be null in case of cancellation
+ if (conn != null) conn.shutdown();
Review comment:
I do not fully understand, here the connection is gotten from a Map, we will
not put null element to the Map?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
