Apache9 commented on a change in pull request #343: HBASE-22634 : Improve 
performance of BufferedMutator        
URL: https://github.com/apache/hbase/pull/343#discussion_r297930078
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
 ##########
 @@ -235,6 +245,13 @@ public synchronized void close() throws IOException {
     }
     // Stop any running Periodic Flush timer.
     disableWriteBufferPeriodicFlush();
+    ap.waitAllSlot();
+    try {
+      // Let time to the periodic flush thread to exit (task are finished, but 
not the code after)
+      Thread.sleep(5);
 
 Review comment:
   Is this stable enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to