[ https://issues.apache.org/jira/browse/HBASE-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241399#comment-13241399 ]
Hadoop QA commented on HBASE-5617: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520451/HBASE-5617_2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1343//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1343//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1343//console This message is automatically generated. > Provide coprocessor hooks in put flow while rollbackMemstore. > ------------------------------------------------------------- > > Key: HBASE-5617 > URL: https://issues.apache.org/jira/browse/HBASE-5617 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Fix For: 0.96.0 > > Attachments: HBASE-5617_1.patch, HBASE-5617_2.patch > > > With coprocessors hooks while put happens we have the provision to create new > puts to other tables or regions. These puts can be done with writeToWal as > false. > In 0.94 and above the puts are first written to memstore and then to WAL. If > any failure in the WAL append or sync the memstore is rollbacked. > Now the problem is that if the put that happens in the main flow fails there > is no way to rollback the > puts that happened in the prePut. > We can add coprocessor hooks to like pre/postRoolBackMemStore. Is any one > hook enough here? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira