[
https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916774#comment-16916774
]
Anoop Sam John commented on HBASE-22760:
----------------------------------------
private static final String DEFAULT_SNAPSHOT_CLEANUP_ZNODE = "snapshot-cleanup";
Should we name it snapshot-autoclean? And same way other related like
zookeeper.znode.snapshot.cleanup.. In all related places is it better to say
autoclean instead of cleanup?
By default this auto cleanup thread is ON right
message SnapshotCleanupState {
30 optional bool snapshot_cleanup_enabled = 1;
31 }
Why it is optional? If this PB message is written to zk, it must have this
boolean right? In that angle it should be required?
final boolean prevSnapshotCleanupRunning = request.getSynchronous() ?
1504 this.switchSnapshotCleanup(enabled, true) :
1505 this.switchSnapshotCleanup(enabled, false);
Synchronous is optional in the PB request and so you should do hasSynchronous?
If req hasSynchronous then this.switchSnapshotCleanup(enabled,
request.getSynchronous())
We can have switchSnapshotCleanup method itself synchronized to have a
consistent prevState return value?
you can pass Synchronous param to HMaster#switchSnapshotCleanup() and handle
wait for completion of the chore cur run. So you can avoid exposing
SnapshotCleanerChore getSnapshotCleanerChore();
In shell command not using Synchronous param?
> Stop/Resume Snapshot Auto-Cleanup activity with shell command
> -------------------------------------------------------------
>
> Key: HBASE-22760
> URL: https://issues.apache.org/jira/browse/HBASE-22760
> Project: HBase
> Issue Type: Improvement
> Components: Admin, shell, snapshots
> Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11
>
> Attachments: HBASE-22760.master.003.patch,
> HBASE-22760.master.004.patch, HBASE-22760.master.005.patch,
> HBASE-22760.master.008.patch
>
>
> For any scheduled snapshot backup activity, we would like to disable
> auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a
> config to disable snapshot auto-cleaner:
> hbase.master.cleaner.snapshot.disable, which would take effect only upon
> HMaster restart just similar to any other hbase-site configs.
> For any running cluster, we should be able to stop/resume auto-cleanup
> activity for snapshot based on shell command. Something similar to below
> command should be able to stop/start cleanup chore:
> hbase(main):001:0> snapshot_auto_cleanup_switch false (disable
> auto-cleaner)
> hbase(main):001:0> snapshot_auto_cleanup_switch true (enable auto-cleaner)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
