[
https://issues.apache.org/jira/browse/HBASE-22760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917420#comment-16917420
]
Viraj Jasani commented on HBASE-22760:
--------------------------------------
{quote}Is this an unintentional change?
{quote}
This is intentional removal of master site config we used for
enabling/disabling snapshot cleanup chore run. With this patch, since we are
moving to _switch command, we can get rid of master site config.
Here is the shift from config to shell command and hence we are not using
config anymore:
{code:java}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
index 74611d04a5..75772a707c 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
- final boolean isSnapshotChoreDisabled =
conf.getBoolean(HConstants.SNAPSHOT_CLEANER_DISABLE,
- false);
- if (isSnapshotChoreDisabled) {
+ final boolean isSnapshotChoreEnabled = this.snapshotCleanupTracker
+ .isSnapshotCleanupEnabled();
+ this.snapshotCleanerChore = new SnapshotCleanerChore(this, conf,
getSnapshotManager());
+ if (isSnapshotChoreEnabled) {
+ getChoreService().scheduleChore(this.snapshotCleanerChore);
+ } else {
{code}
> Stop/Resume Snapshot Auto-Cleanup activity with shell command
> -------------------------------------------------------------
>
> Key: HBASE-22760
> URL: https://issues.apache.org/jira/browse/HBASE-22760
> Project: HBase
> Issue Type: Improvement
> Components: Admin, shell, snapshots
> Affects Versions: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.4.11
>
> Attachments: HBASE-22760.master.003.patch,
> HBASE-22760.master.004.patch, HBASE-22760.master.005.patch,
> HBASE-22760.master.008.patch, HBASE-22760.master.009.patch
>
>
> For any scheduled snapshot backup activity, we would like to disable
> auto-cleaner for snapshot based on TTL. However, as per HBASE-22648 we have a
> config to disable snapshot auto-cleaner:
> hbase.master.cleaner.snapshot.disable, which would take effect only upon
> HMaster restart just similar to any other hbase-site configs.
> For any running cluster, we should be able to stop/resume auto-cleanup
> activity for snapshot based on shell command. Something similar to below
> command should be able to stop/start cleanup chore:
> hbase(main):001:0> snapshot_auto_cleanup_switch false (disable
> auto-cleaner)
> hbase(main):001:0> snapshot_auto_cleanup_switch true (enable auto-cleaner)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
