busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323340269
########## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt ########## @@ -0,0 +1,26 @@ +Apache HBase - Kafka Model +Copyright 2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +==== +Apache HBase - Kafka Model contained works + +This product contains additional works that are distributed under licenses +other than Apache Software License Version 2. See LICENSE for full details + +---- +This product includes the SLF4J API Module Review comment: are these things that end up in the jar file for hbase-kafka-model? it doesn't seem like we should. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
