busbey commented on a change in pull request #41: HBASE-22338 LICENSE file only contains Apache 2.0. URL: https://github.com/apache/hbase-connectors/pull/41#discussion_r323947041
########## File path: kafka/hbase-kafka-model/src/main/appended-resources/META-INF/NOTICE.txt ########## @@ -0,0 +1,26 @@ +Apache HBase - Kafka Model +Copyright 2019 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +==== +Apache HBase - Kafka Model contained works + +This product contains additional works that are distributed under licenses +other than Apache Software License Version 2. See LICENSE for full details + +---- +This product includes the SLF4J API Module Review comment: that file just tells some tools that look at the jar what dependencies are needed at runtime. It doesn't mean we're packaging and distributing them. a given LICENSE/NOTICE set of files should only cover the artifact they're found in. So each of these module should have a `src/main/appended-resources/META-INF/LICENSE`/`NOTICE` based on the contents of the jar that will be made by that module. the only case where these would include dependencies is if we are making a "fat jar" or using the maven shade plugin to package our dependency into the jar. I *think* that means for the connectors repo, it's only the convenience binary tarball that needs the aggregate information about our dependencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
