anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due to DBE reference to an reused ByteBuff URL: https://github.com/apache/hbase/pull/603#discussion_r323557399
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodingState.java ########## @@ -31,4 +32,15 @@ * The previous Cell the encoder encoded. */ protected Cell prevCell = null; + + @VisibleForTesting + public Cell getLastCell() { + return prevCell; + } + + public void beforeShipped() { Review comment: Why not making it ShipperListener. That would be best ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services