anoopsjohn commented on a change in pull request #603: HBASE-22965 RS Crash due
to DBE reference to an reused ByteBuff
URL: https://github.com/apache/hbase/pull/603#discussion_r323557944
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
##########
@@ -781,6 +783,11 @@ public Cell getLastCell() {
return lastCell;
}
+ @VisibleForTesting
Review comment:
So many method exposes for the test-ability. Are we really testing the FT
way? That a prevCell been passed and we pollute that cell's backing BB/byte[]
after a shipped call? That would be the best and in that I dont think we need
to expose these many method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
