busbey commented on a change in pull request #616: HBASE-23015 : Moving from 
Jackson2 to shaded Gson
URL: https://github.com/apache/hbase/pull/616#discussion_r323774798
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java
 ##########
 @@ -52,11 +51,9 @@
  * This class is not thread safe.
  */
 @InterfaceAudience.Private
-@JsonIgnoreProperties({"indexStatistics", "freeSize", "usedSize"})
 
 Review comment:
   It looks like not all of these have been replaced with something getting 
marked `transient`. did you take a look at the JSON output to make sure we're 
not getting something surprising?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to