busbey commented on a change in pull request #616: HBASE-23015 : Moving from
Jackson2 to shaded Gson
URL: https://github.com/apache/hbase/pull/616#discussion_r323768816
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheUtil.java
##########
@@ -102,15 +121,10 @@ public String getFilename() {
}
/**
- * @param filename
- * @param blocks
* @return A JSON String of <code>filename</code> and counts of
<code>blocks</code>
- * @throws JsonGenerationException
- * @throws JsonMappingException
- * @throws IOException
*/
- public static String toJSON(final String filename, final
NavigableSet<CachedBlock> blocks)
- throws JsonGenerationException, JsonMappingException, IOException {
+ public static String toJSON(String filename, NavigableSet<CachedBlock>
blocks)
Review comment:
can we leave the `final` modifiers in place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
