saintstack commented on a change in pull request #762: HBASE-23157 WAL
unflushed seqId tracking may wrong when Durability.AS…
URL: https://github.com/apache/hbase/pull/762#discussion_r339368585
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestFSWAL.java
##########
@@ -186,12 +193,10 @@ protected void addEdits(WAL log, RegionInfo hri,
TableDescriptor htd, int times,
/**
* helper method to simulate region flush for a WAL.
- * @param wal
- * @param regionEncodedName
*/
protected void flushRegion(WAL wal, byte[] regionEncodedName, Set<byte[]>
flushedFamilyNames) {
wal.startCacheFlush(regionEncodedName, flushedFamilyNames);
- wal.completeCacheFlush(regionEncodedName);
+ wal.completeCacheFlush(regionEncodedName, HConstants.NO_SEQNUM);
Review comment:
Should completeCacheFlush check for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
