[ https://issues.apache.org/jira/browse/HBASE-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249328#comment-13249328 ]
Lars Hofhansl commented on HBASE-5720: -------------------------------------- That patch looks like it should work. As I mention in an earlier comment, though, this strategy is brittle especially considering future changes. At the same time I cannot think of anything better offhand. Let me move the trunk discussion into another jira and commit the 0.94 fix via this one. Everybody OK with that? > HFileDataBlockEncoderImpl uses wrong header size when reading HFiles with no > checksums > -------------------------------------------------------------------------------------- > > Key: HBASE-5720 > URL: https://issues.apache.org/jira/browse/HBASE-5720 > Project: HBase > Issue Type: Bug > Components: io, regionserver > Affects Versions: 0.94.0 > Reporter: Matt Corgan > Priority: Blocker > Fix For: 0.94.0 > > Attachments: 5720-trunk-v2.txt, 5720-trunk.txt, 5720v4.txt, > 5720v4.txt, 5720v4.txt, HBASE-5720-v1.patch, HBASE-5720-v2.patch, > HBASE-5720-v3.patch > > > When reading a .92 HFile without checksums, encoding it, and storing in the > block cache, the HFileDataBlockEncoderImpl always allocates a dummy header > appropriate for checksums even though there are none. This corrupts the > byte[]. > Attaching a patch that allocates a DUMMY_HEADER_NO_CHECKSUM in that case > which I think is the desired behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira