brfrn169 commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs URL: https://github.com/apache/hbase/pull/722#discussion_r340416956
########## File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenModel.java ########## @@ -155,11 +158,13 @@ public boolean addFilter(String filterString, boolean ignoreCase) { } filters.add(filter); + decomposePushDownFilter(); Review comment: Let me check if there is no harm or not locally. I'm suspecting that when a user add a filter after drill-down in user/client mode, pushDownFilters will be cleared in decomposePushDownFilter(), which is a problem. Will run this feature locally and check that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services