brfrn169 commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N
heavy hitter user and client drill downs
URL: https://github.com/apache/hbase/pull/722#discussion_r344085320
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -1384,7 +1386,15 @@ RegionSpaceUse convertRegionSize(RegionInfo regionInfo,
Long sizeInBytes) {
} else {
serverLoad.setInfoServerPort(-1);
}
-
+ MetricsUserAggregateSource userSource =
+ metricsRegionServer.getMetricsUserAggregate().getSource();
+ if (userSource != null) {
+ UserLoad.Builder userLoadBldr = UserLoad.newBuilder();
Review comment:
This builder instantiation should be in createUserLoad(). It looks like it's
causing wrong metric values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
