[ https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249405#comment-13249405 ]
stack commented on HBASE-5604: ------------------------------ On the patch, can we play all edits from all passed in WALs or does it have to be by a specific table only? I think it'd be nice to be able to pass a list of tables but thats just a 'nice-to-have'. I think it more important we play edits for one table or all (Could do the 'all' in another JIRA. Could add time range to include in another issue too) We check if a meta table and if it is one, we just skip? Whats up w/ that? Maybe I want to use this tool to restore meta table? If you don't want it used on meta, fail earlier if we are passed a meta table to use as table. Make this a LOG rather than a stdout + e.printStackTrace(); Make it a versionedwritable instead in the below? + static class HLogSplit extends InputSplit implements Writable { Usual style is to have space around operators. Try the fb lint on your patch? Patch looks good. +1 on commit. Add a release note. > HLog replay tool that generates HFiles for use by LoadIncrementalHFiles. > ------------------------------------------------------------------------ > > Key: HBASE-5604 > URL: https://issues.apache.org/jira/browse/HBASE-5604 > Project: HBase > Issue Type: New Feature > Reporter: Lars Hofhansl > Attachments: 5604-v4.txt, HLog-5604-v3.txt > > > Just an idea I had. Might be useful for restore of a backup using the HLogs. > This could an M/R (with a mapper per HLog file). > The tool would get a timerange and a (set of) table(s). We'd pick the right > HLogs based on time before the M/R job is started and then have a mapper per > HLog file. > The mapper would then go through the HLog, filter all WALEdits that didn't > fit into the time range or are not any of the tables and then uses > HFileOutputFormat to generate HFiles. > Would need to indicate the splits we want, probably from a live table. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira