[ 
https://issues.apache.org/jira/browse/HBASE-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249431#comment-13249431
 ] 

Lars Hofhansl commented on HBASE-5604:
--------------------------------------

Thanks Stack.

The meta check is actually for "meta" entries in the WAL (see 
HLog.completeCacheFlushLogEdit), not edits to the ROOT or META. I'll add a 
comment to that extend. ROOT and META could be passed as <tablename> and it 
would do the right thing.

The printStackTrace I took from Import. Just means that the message will show 
up in the Jobs stderr rather then syslog. I think that is what we want? Can 
change, though.

Playing all edits or edit from multiple tables does not allow me to use 
TableOutputFormat or HFileOutputFormat. I can use MultiTableOutputFormat for 
the live cluster case, and change the mappers to output the tablename as key.
For bulk output to HFiles that would tricky. +1 on doing that, though, for a 
full backup option.

Maybe allow all or a set of tables for the live cluster case and only allow a 
single table for the Bulk output case. I'll do that.

Re: coding style... I thought I followed the standard :) Will use FBs lint.

                
> HLog replay tool that generates HFiles for use by LoadIncrementalHFiles.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-5604
>                 URL: https://issues.apache.org/jira/browse/HBASE-5604
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>         Attachments: 5604-v4.txt, HLog-5604-v3.txt
>
>
> Just an idea I had. Might be useful for restore of a backup using the HLogs.
> This could an M/R (with a mapper per HLog file).
> The tool would get a timerange and a (set of) table(s). We'd pick the right 
> HLogs based on time before the M/R job is started and then have a mapper per 
> HLog file.
> The mapper would then go through the HLog, filter all WALEdits that didn't 
> fit into the time range or are not any of the tables and then uses 
> HFileOutputFormat to generate HFiles.
> Would need to indicate the splits we want, probably from a live table.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to