ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member visibility in HRegionServer URL: https://github.com/apache/hbase/pull/775#discussion_r341361136
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java ########## @@ -331,47 +328,36 @@ // Go down hard. Used if file system becomes unavailable and also in // debugging and unit tests. private volatile boolean abortRequested; - public static final String ABORT_TIMEOUT = "hbase.regionserver.abort.timeout"; + static final String ABORT_TIMEOUT = "hbase.regionserver.abort.timeout"; // Default abort timeout is 1200 seconds for safe private static final long DEFAULT_ABORT_TIMEOUT = 1200000; // Will run this task when abort timeout - public static final String ABORT_TIMEOUT_TASK = "hbase.regionserver.abort.timeout.task"; - - ConcurrentMap<String, Integer> rowlocks = new ConcurrentHashMap<>(); Review comment: This field is flagged as unused by static analysis. It's possible that something in the scope of `HIA.TOOLS` is reaching in for it, but if the region server itself never uses it, then it's a variable that could be local to the tool that's using it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
