ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r341377173
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1291,7 +1295,8 @@ protected RpcServerInterface createRpcServer(Server
server, Configuration conf,
}
protected Class<?> getRpcSchedulerFactoryClass() {
- return
this.regionServer.conf.getClass(REGION_SERVER_RPC_SCHEDULER_FACTORY_CLASS,
Review comment:
True. Breaking up these compound statements makes it easier to see NPEs when
they happen. I guess such stylistic choices will become obsolete once Java14
lands.
https://bugs.openjdk.java.net/browse/JDK-8218628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
