apurtell commented on a change in pull request #781: HBASE-18095: 
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r342212992
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
 ##########
 @@ -3067,6 +3075,19 @@ public Connection getConnection() throws IOException {
     return this.asyncConnection.toConnection();
   }
 
+  /**
+   * Creates a new Connection instance for this mini cluster with a given 
input config. Use it wisely since
+   * connection creation is expensive. For all practical purposes 
@link(getConnection()) should be good enough. This
+   * helper should only used if one wants to test a custom client side 
configuration that differs from the conf used to
+   * spawn the mini-cluster.
+   */
+  public AsyncClusterConnection getCustomConnection(Configuration conf) throws 
IOException {
 
 Review comment:
   This is confusing.
   "Custom"? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to