apurtell commented on a change in pull request #781: HBASE-18095: 
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r342201598
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegistryFactory.java
 ##########
 @@ -27,7 +27,7 @@
 @InterfaceAudience.Private
 final class AsyncRegistryFactory {
 
-  static final String REGISTRY_IMPL_CONF_KEY = "hbase.client.registry.impl";
+  public static final String REGISTRY_IMPL_CONF_KEY = 
"hbase.client.registry.impl";
 
 Review comment:
   So the idea here is the clients will instantiate one type of REGISTRY_IMPL, 
which contacts masters via RPC, and the masters will instantiate another type 
of REGISTRY_IMPL that talks to zookeeper directly? How is the distinction 
managed? Maybe I'll answer my own question upon further review...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to