bharathv commented on a change in pull request #808: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/808#discussion_r344271230
##########
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
##########
@@ -259,6 +259,7 @@ protected void startInfoServer() throws IOException {
.get(THRIFT_INFO_SERVER_BINDING_ADDRESS,
THRIFT_INFO_SERVER_BINDING_ADDRESS_DEFAULT);
infoServer = new InfoServer("thrift", a, port, false, conf);
infoServer.setAttribute("hbase.conf", conf);
+ infoServer.setAttribute("hbase.thrift.type",
metrics.getThriftServerType());
Review comment:
nit: hbase.thrift.server.type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
